MIME-Version: 1.0
From: someone@example.com
To: everyone@example.com.com
Subject: [727] CSS tweaks.
X-Mailer: SVN::Notify 2.21: http://search.cpan.org/dist/SVN-Notify/
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
Date: Sat,  9 Oct 2004 12:55:37 -0700 (PDT)

Revision
727
Author
someone
Date
2004-10-09 12:55:37 -0700 (Sat, 09 Oct 2004)

Log Message

CSS tweaks. Added "Diff" header. Incremented version to 2.20.

Modified Files

Diff

trunk/SVN-Notify/Changes (726 => 727)

--- trunk/SVN-Notify/Changes	2004-10-09 19:28:09 UTC (rev 726)
+++ trunk/SVN-Notify/Changes	2004-10-09 19:55:37 UTC (rev 727)
@@ -1,6 +1,6 @@
 Revision history for Perl extension SVN::Notify
 
-2.11
+2.20
       - Subclassing Module::Build in Build.PL to move and set the shebang
         line in test scripts during "./Build" instead of simply changing
         the shebang line in-place during "perl Build.PL".

trunk/SVN-Notify/META.yml (726 => 727)

--- trunk/SVN-Notify/META.yml	2004-10-09 19:28:09 UTC (rev 726)
+++ trunk/SVN-Notify/META.yml	2004-10-09 19:55:37 UTC (rev 727)
@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name: SVN-Notify
-version: 2.11
+version: 2.20
 author:
   - David Wheeler <david@kineticode.com>
 abstract: Subversion activity notification
@@ -17,11 +17,11 @@
 provides:
   SVN::Notify:
     file: lib/SVN/Notify.pm
-    version: 2.11
+    version: 2.20
   SVN::Notify::HTML:
     file: lib/SVN/Notify/HTML.pm
-    version: 2.11
+    version: 2.20
   SVN::Notify::HTML::ColorDiff:
     file: lib/SVN/Notify/HTML/ColorDiff.pm
-    version: 2.11
+    version: 2.20
 generated_by: Module::Build version 0.25_03

trunk/SVN-Notify/README (726 => 727)

--- trunk/SVN-Notify/README	2004-10-09 19:28:09 UTC (rev 726)
+++ trunk/SVN-Notify/README	2004-10-09 19:55:37 UTC (rev 727)
@@ -1,4 +1,4 @@
-SVN/Notify version 2.11
+SVN/Notify version 2.20
 =======================
 
 This class may be used for sending email messages for Subversion repository

trunk/SVN-Notify/lib/SVN/Notify/HTML/ColorDiff.pm (726 => 727)

--- trunk/SVN-Notify/lib/SVN/Notify/HTML/ColorDiff.pm	2004-10-09 19:28:09 UTC (rev 726)
+++ trunk/SVN-Notify/lib/SVN/Notify/HTML/ColorDiff.pm	2004-10-09 19:55:37 UTC (rev 727)
@@ -6,7 +6,7 @@
 use HTML::Entities;
 use SVN::Notify::HTML ();
 
-$SVN::Notify::HTML::ColorDiff::VERSION = '2.11';
+$SVN::Notify::HTML::ColorDiff::VERSION = '2.20';
 @SVN::Notify::HTML::ColorDiff::ISA = qw(SVN::Notify::HTML);
 
 =head1 Name
@@ -63,11 +63,12 @@
     my ($self, $out) = @_;
     $self->SUPER::output_css($out);
     print $out
-      qq(#patch .file h3 {padding: 0 10px;line-height:1.5em;font-size:.85em;),
+      qq(#patch .file h3 {padding: 0 10px;line-height:1.5em;),
         qq(margin:0;background:#ccffff;border-bottom:1px solid black;),
         qq(margin:0 0 10px 0;}\n),
-      qq(#patch pre {background:#eeeeee;padding:0;line-height:1.2em;),
+      qq(#patch pre {padding:0;line-height:1.2em;),
         qq(margin:0;}\n),
+      qq(#patch .diff {background:#eeeeee;padding: 0 0 10px 0;}\n),
       qq(#patch span {display:block;padding:0 10px;}\n),
       qq(#patch .file {border:1px solid black;margin:10px 0;}\n),
       qq(#patch .add {background:#ddffdd;}\n),
@@ -98,7 +99,7 @@
 
     my $in_div;
     my $in_span = '';
-    print $out qq{<div id="patch">\n};
+    print $out qq{</div>\n<div id="patch">\n<h3>Diff</h3>\n};
     while (my $line = <$diff>) {
         $line =~ s/[\n\r]+$//;
         next unless $line;
@@ -118,7 +119,7 @@
             # Output the headers.
             print $out "</span>" if $in_span;
             print $out "</pre></div>\n" if $in_div;
-            print $out qq{<div class="file"><h3><a id="$file">$file</a>},
+            print $out qq{<a id="$file"></a>\n<div class="file"><h3>$file},
               " ($rev1 => $rev2)</h3>\n";
             print $out qq{<pre class="diff">\n<span class="info">};
             $in_div = 1;

trunk/SVN-Notify/lib/SVN/Notify/HTML.pm (726 => 727)

--- trunk/SVN-Notify/lib/SVN/Notify/HTML.pm	2004-10-09 19:28:09 UTC (rev 726)
+++ trunk/SVN-Notify/lib/SVN/Notify/HTML.pm	2004-10-09 19:55:37 UTC (rev 727)
@@ -6,7 +6,7 @@
 use HTML::Entities;
 use SVN::Notify ();
 
-$SVN::Notify::HTML::VERSION = '2.11';
+$SVN::Notify::HTML::VERSION = '2.20';
 @SVN::Notify::HTML::ISA = qw(SVN::Notify);
 
 =head1 Name
@@ -84,7 +84,7 @@
     my ($self, $out) = @_;
     print $out qq{<html>\n<head><style type="text/css"><!--\n};
     $self->output_css($out);
-    print $out qq{\n--></style>\n</head>\n<body>\n\n<div id="msg">\n};
+    print $out qq{--></style>\n</head>\n<body>\n\n<div id="msg">\n};
     return $self;
 }
 
@@ -103,17 +103,16 @@
 sub output_css {
     my ($self, $out) = @_;
     print $out
-      qq(sans-serif;font-size:85%;}\n),
-      qq(pre {font-size:125%;}\n),
+      qq(body {background:#ffffff;font-family:Verdana,Helvetica,Arial,sans-serif;}\n),
       qq(h3 {margin:15px 0;padding:0;line-height:0;}\n),
       qq(#msg {margin: 0 0 2em 0;}\n),
       qq(#msg dl, #msg ul, #msg pre {padding:1em;border:1px dashed black;),
-        qq(margin: 10px 0 30px 0;}),
-      qq(#msg dl {background:#ccccff;}),
-      qq(#msg pre {background:#ffffcc;}),
-      qq(#msg ul {background:#cc99ff;list-style:none;}),
-      qq(#msg dt {font-weight:bold;float:left;width: 6em;}),
-      qq(#msg dt:after { content:':';});
+        qq(margin: 10px 0 30px 0;}\n),
+      qq(#msg dl {background:#ccccff;}\n),
+      qq(#msg pre {background:#ffffcc;}\n),
+      qq(#msg ul {background:#cc99ff;list-style:none;}\n),
+      qq(#msg dt {font-weight:bold;float:left;width: 6em;}\n),
+      qq(#msg dt:after { content:':';}\n);
     return $self;
 }
 

trunk/SVN-Notify/lib/SVN/Notify.pm (726 => 727)

--- trunk/SVN-Notify/lib/SVN/Notify.pm	2004-10-09 19:28:09 UTC (rev 726)
+++ trunk/SVN-Notify/lib/SVN/Notify.pm	2004-10-09 19:55:37 UTC (rev 727)
@@ -3,7 +3,7 @@
 # $Id$
 
 use strict;
-$SVN::Notify::VERSION = '2.11';
+$SVN::Notify::VERSION = '2.20';
 
 =head1 Name
 

trunk/SVN-Notify/t/colordiff.t (726 => 727)

--- trunk/SVN-Notify/t/colordiff.t	2004-10-09 19:28:09 UTC (rev 726)
+++ trunk/SVN-Notify/t/colordiff.t	2004-10-09 19:55:37 UTC (rev 727)
@@ -9,7 +9,7 @@
 if ($^O eq 'MSWin32') {
     plan skip_all => "SVN::Notify::HTML::ColorDiff not yet supported on Win32";
 } elsif (eval { require HTML::Entities }) {
-    plan tests => 102;
+    plan tests => 103;
 } else {
     plan skip_all => "SVN::Notify::HTML::ColorDiff requires HTML::Entities";
 }
@@ -63,7 +63,7 @@
 # Make sure we have styles and the appropriate div.
 like( $email, qr|<style type="text/css">|, "Check for <style> tag" );
 like( $email, qr/<\/style>/, "Check for </style> tag" );
-like( $email, qr/pre {font-size:125%;}/, "Check for style" );
+like( $email, qr/#patch .add {background:#ddffdd;}/, "Check for style" );
 like( $email, qr/<div id="msg">/, "Check for msg div" );
 
 # Make sure we have headers for each of the four kinds of changes.
@@ -145,7 +145,9 @@
 
 # Make sure that the diff is included and escaped.
 like( $email, qr/<div id="patch">/, "Check for patch div" );
-like( $email, qr{<h3><a id="trunk/Params-CallbackRequest/Changes">trunk/Params-CallbackRequest/Changes</a> \(600 => 601\)</h3>},
+like( $email, qr{<a id="trunk/Params-CallbackRequest/Changes"></a>\n},
+      "Check for file div ID");
+like( $email, qr{<h3>trunk/Params-CallbackRequest/Changes \(600 => 601\)</h3>},
       "Check for diff file header" );
 
 # Make sure that it's not attached.

trunk/SVN-Notify/t/html.t (726 => 727)

--- trunk/SVN-Notify/t/html.t	2004-10-09 19:28:09 UTC (rev 726)
+++ trunk/SVN-Notify/t/html.t	2004-10-09 19:55:37 UTC (rev 727)
@@ -62,7 +62,7 @@
 # Make sure we have styles and the appropriate div.
 like( $email, qr|<style type="text/css">|, "Check for <style> tag" );
 like( $email, qr/<\/style>/, "Check for </style> tag" );
-like( $email, qr/pre {font-size:125%;}/, "Check for style" );
+like( $email, qr/#msg dl {background:#ccccff;}/, "Check for style" );
 like( $email, qr/<div id="msg">/, "Check for msg div" );
 
 # Make sure we have headers for each of the four kinds of changes.